linux-kernel - Re: sony-laptop driver: Volume keys on Sony Vaio TX3 don't work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E9B6511.4060107@calvaedi.com>
Date:	Mon, 17 Oct 2011 01:13:21 +0200
From:	John Hughes <john@...vaedi.com>
To:	Valdis.Kletnieks@...edu
CC:	John Hughes <john@...va.COM>, linux-kernel@...r.kernel.org,
	Mattia Dongili <malattia@...ux.it>,
	Stelian Pop <stelian@...ies.net>
Subject: Re: sony-laptop driver: Volume keys on Sony Vaio TX3 don't work

On 10/16/2011 08:20 PM, Valdis.Kletnieks@...edu wrote:
> On Sun, 16 Oct 2011 19:45:14 +0200, John Hughes said:
>    
>
>> Here's a patch that makes the volume keys work for me.  Tested on
>> current git
>>      
> Do we know if this is applicable to all Sony laptops, or only a few 
> busticated
> models?
>
>
>    
The current code is simply wrong.  It might work by accident on some 
models, but.,..


(Why wrong? it says event (0x01,0x05) is PROG1, but event (0x01, 0x05) 
is Volume up,  Make up your mind please.  PS it's volume DOWN not up).

Wouldn't it be easier just to leave the decision for user mode?  Make 
the different events generate different "scancodes" and let udev sort 
them out?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/