linux-kernel - sony-laptop driver: Volume keys on Sony Vaio TX3 don't work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E9ABBF6.3000504@calvaedi.com>
Date:	Sun, 16 Oct 2011 13:11:50 +0200
From:	John Hughes <john@...vaedi.com>
To:	linux-kernel@...r.kernel.org, Mattia Dongili <malattia@...ux.it>,
	Stelian Pop <stelian@...ies.net>
Subject: sony-laptop driver: Volume keys on Sony Vaio TX3 don't work

Even though sony-laptop has code to handle the volume-up/volume-down 
keys they don't work.  Pressing volume-down gets treated as 
SONYPI_EVENT_PKEY_P1 and volume-up as SONYPI_EVENT_PKEY_P2.

This is because volume-down generates event 0x01 with data mask 0x05 and 
although the sonypi_volumeev table exists to handle this the table 
sonypi_pkeyev steals the event before it gets handled.

Re-ordering the entries in the table type3_events and fixing the bug in 
sonypi_volumeev (up and down were inverted) makes the volume keys work.

See attached patch.

The two remaining problems are:

1. the EJECT key is mapped to FN_E
2. the MUTE key (event 5f, 31) is mapped to nothing.   (Not to important 
as it turns the speaker off in hardware).

View attachment "sony-vaio-tx3.patch" of type "text/x-patch" (946 bytes)