linux-kernel - Re: [PATCH v2] staging: mei: clean the TODO file from done tasks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111016142610.GA21921@jak-linux.org>
Date:	Sun, 16 Oct 2011 16:26:10 +0200
From:	Julian Andres Klode <jak@...-linux.org>
To:	Oren Weil <oren.jer.weil@...el.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	tomas.winkler@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: mei: clean the TODO file from done tasks.

On Sun, Oct 16, 2011 at 03:45:19PM +0200, Oren Weil wrote:
> 1) we move the AMT Watchdog to use the kernel watchdog core and
> it is still part of the MEI Driver, we didn't see any reason to extract it
> from the mei driver now with the new watchdog core.
Not understandable. You need a few transition words instead of just
putting a few unrelated sentences after each other.

> 2) since the watchdog is remains in mei driver, exposing in kernel
> api just for AMTHI unnecessary.
You have a verb (is) too much, and you miss a "the" before
"mei driver". "in kernel" should be "in-kernel", "api" should
be "API". And you miss an "is" after AMTHI (whatever AMTHI
is).

> 
> MEI new Watchdog Core Interface Patches set:
> https://lkml.org/lkml/2011/9/7/26
You are missing a verb here.

> 
> 3) Cleanup the code (init and probe, bug_on usage, headers and etc) was
> submitted in previous patches.
"Code cleanup" instead of "Cleanup the code"

> 
> Patches:
> https://lkml.org/lkml/2011/9/21/231
> https://lkml.org/lkml/2011/6/15/358
> https://lkml.org/lkml/2011/7/7/177
> https://lkml.org/lkml/2011/9/7/38
> https://lkml.org/lkml/2011/9/7/37
> https://lkml.org/lkml/2011/9/7/28
> 
> 
> 4) mei.txt was update with additional information in previous patches.
                      ^	(missing d)

In general, prose text tends to be much more readable than a list
of sentences. At least writing a short introduction in prose would
be helpful.

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/