linux-kernel - Re: [PATCH 06/10] mmc-host: move to dma_transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E9BFBB3.805@atmel.com>
Date:	Mon, 17 Oct 2011 11:56:03 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Vinod Koul <vinod.koul@...el.com>
CC:	dan.j.williams@...el.com, linux-kernel@...r.kernel.org,
	jaswinder.singh@...aro.org, 21cnbao@...il.com,
	rmk@....linux.org.uk, Vinod Koul <vinod.koul@...ux.intel.com>,
	Chris Ball <cjb@...top.org>,
	Guennadi Liakhovetski <g.liakhovetski@....de>
Subject: Re: [PATCH 06/10] mmc-host: move to dma_transfer_direction

On 10/14/2011 07:38 AM, Vinod Koul :
> From: Vinod Koul <vinod.koul@...ux.intel.com>
> 
> Signed-off-by: Vinod Koul <vinod.koul@...ux.intel.com>
> Cc: Nicolas Ferre <nicolas.ferre@...el.com>
> Cc: Chris Ball <cjb@...top.org>
> Cc: Guennadi Liakhovetski <g.liakhovetski@....de>
> ---
>  drivers/mmc/host/atmel-mci.c    |    9 ++++++---

[..]

> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -681,16 +681,19 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
>  	if (atmci_is_mci2())
>  		mci_writel(host, DMA, MCI_DMA_CHKSIZE(3) | MCI_DMAEN);
>  
> -	if (data->flags & MMC_DATA_READ)
> +	if (data->flags & MMC_DATA_READ) {
>  		direction = DMA_FROM_DEVICE;
> -	else
> +		slave_dirn = DEV_TO_MEM;

It seems that the slave_dirn declaration is missing...

> +	} else {
>  		direction = DMA_TO_DEVICE;
> +		slave_dirn = MEM_TO_DEV;
> +	}
>  
>  	sglen = dma_map_sg(chan->device->dev, data->sg,
>  			   data->sg_len, direction);
>  
>  	desc = chan->device->device_prep_slave_sg(chan,
> -			data->sg, sglen, direction,
> +			data->sg, sglen, slave_dirn,
>  			DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
>  	if (!desc)
>  		goto unmap_exit;

When fixed:

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Best regards,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/