linux-kernel - Re: [PATCH][TRIVIAL] [thermal] fix unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADZ9YHjF-xwfc7sxGz+ih-S0Xa+XNcDBx3e15=acdMyiQVm-Kw@mail.gmail.com>
Date:	Mon, 17 Oct 2011 17:23:48 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	Daniel Walter <d.walter@...0.at>
Cc:	rui.zhang@...el.com, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH][TRIVIAL] [thermal] fix unused variable warning

Hi Daniel,

On Mon, Oct 10, 2011 at 4:05 PM, Daniel Walter <d.walter@...0.at> wrote:
> [thermal] fix unused variable warning
>
> thermal_event_seqnum is only used if CONFIG_NET is defined.
>
> Signed-off-by: Daniel Walter <d.walter@...0.at>
> ---
>  drivers/thermal/thermal_sys.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> ---
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 708f8e9..def02da 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -60,7 +60,9 @@ static LIST_HEAD(thermal_tz_list);
>  static LIST_HEAD(thermal_cdev_list);
>  static DEFINE_MUTEX(thermal_list_lock);
>
> +#ifdef CONFIG_NET
>  static unsigned int thermal_event_seqnum;
> +#endif /* CONFIG_NET */
>
I think, it would be nice to move thermal_event_seqnum under
CONFIG_NET defined section, instead of wrapping with CONFIG_NET.
Although your fix is okay but moving under CONFIG_NET would be nicer.
Something like below:

---
diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
index 708f8e9..b88c6ba 100644
--- a/drivers/thermal/thermal_sys.c
+++ b/drivers/thermal/thermal_sys.c
@@ -60,8 +60,6 @@ static LIST_HEAD(thermal_tz_list);
 static LIST_HEAD(thermal_cdev_list);
 static DEFINE_MUTEX(thermal_list_lock);

-static unsigned int thermal_event_seqnum;
-
 static int get_idr(struct idr *idr, struct mutex *lock, int *id)
 {
        int err;
@@ -1293,6 +1291,8 @@ void thermal_zone_device_unregister(struct
thermal_zone_device *tz)
 EXPORT_SYMBOL(thermal_zone_device_unregister);

 #ifdef CONFIG_NET
+static unsigned int thermal_event_seqnum;
+
 static struct genl_family thermal_event_genl_family = {
        .id = GENL_ID_GENERATE,
        .name = THERMAL_GENL_FAMILY_NAME,


Thanks,
Rakib
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/