linux-kernel - Re: [PATCH] staging:iio:proof of concept in kernel interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111017120813.GB27266@opensource.wolfsonmicro.com>
Date:	Mon, 17 Oct 2011 13:08:14 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jonathan Cameron <jic23@....ac.uk>
Cc:	Linus Walleij <linus.ml.walleij@...il.com>,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	zdevai@...il.com
Subject: Re: [PATCH] staging:iio:proof of concept in kernel interface.

On Mon, Oct 17, 2011 at 12:32:25PM +0100, Jonathan Cameron wrote:
> On 10/17/11 12:18, Mark Brown wrote:

> >  - Some voltage inputs hard wired to particular system supplies.

> Hard wired in the pmic?  (e.g. do not vary from device to device).
> These I'm happy to see have names.  If it were a normal IIO device their
> access attributes would be something like:

> in_voltage0_supply3V_raw
> in_voltage1_supply2.8V_raw

Yes, though the names are more symbolic than that (eg, "USB").

> (have insist on indexing even with named channels because it is needed as
> events codes don't want to carry a string.).

This is orthogonal to the request interface, though.

> >  - One or more temperature inputs wired to particular place (eg, chip
> >    and battery).

> Not hard wired so to my mind these are just general purpose temperature inputs.
> Hence naming doesn't make sense (at least not outside of board file or DT).

No, they're hard wired - like I say they're wired to a particular place.

> There are some complexities to deal with that make me wonder if direct indexing
> into a driver provided table isn't easier.  The other is channel types.

It's not great for usability if you've got to apply an additional layer
of translation on top of mapping the schematic onto the hardware.

> Is it so bad to insist that the dt writer or equivalent actually looks at the
> driver in question and picks the underlying channel index directly?

We certainly can't put Linux specific channel numbers into the device
tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/