linux-kernel - Re: [PATCH] Driver for Primax keyboards violating USB HID spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1110171710570.3541@pobox.suse.cz>
Date:	Mon, 17 Oct 2011 17:11:50 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Terry Lambert <tlambert@...omium.org>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Driver for Primax keyboards violating USB HID spec

On Fri, 14 Oct 2011, Terry Lambert wrote:

> Primax keyboards with the issue this driver addresses report modifier
> keys as in band key events instead of as out of band modifier bits,
> resulting in the modifier keys generating key up events immediately
> before the keys they are intended to modify.  This driver rewrites
> the raw report data from such keyboards into USB HID 1.11 compliant
> report data.  It only matches the USB vendor and product IDs for the
> keyboard it has been tested on. Since there are several keyboards,
> notably a number of laptops and folding USB keyboards known to have
> similar unresolved problem reports, the list is expected to grow.
> 
> Signed-off-by: Terry Lambert <tlambert@...omium.org>
> ---
>  drivers/hid/Kconfig      |    8 +++
>  drivers/hid/Makefile     |    1 +
>  drivers/hid/hid-core.c   |    1 +
>  drivers/hid/hid-ids.h    |    3 +
>  drivers/hid/hid-primax.c |  117 ++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 130 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/hid/hid-primax.c
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 1130a89..a097e17 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -441,6 +441,14 @@ config HID_PICOLCD_LEDS
>  	---help---
>  	  Provide access to PicoLCD's GPO pins via leds class.
>  
> +config HID_PRIMAX
> +	tristate "Primax non-fully HID-compliant devices" if EXPERT
> +	depends on USB_HID
> +	default !EXPERT

I have removed thi 'EXPERT' dependency (please see changelog of commit 
73d5e8f77e8 for rationale behind that) and applied. Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/