linux-kernel - Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15891.1318866651@redhat.com>
Date:	Mon, 17 Oct 2011 16:50:51 +0100
From:	David Howells <dhowells@...hat.com>
To:	James Morris <jmorris@...ei.org>
Cc:	dhowells@...hat.com, Dmitry Kasatkin <dmitry.kasatkin@...el.com>,
	linux-security-module@...r.kernel.org,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	zohar@...ux.vnet.ibm.com, herbert@...dor.hengli.com.au
Subject: Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

James Morris <jmorris@...ei.org> wrote:

> > +MPI mpi_alloc(unsigned nlimbs)
> > +{
> > +	MPI a;
> > +
> > +	a = (MPI) kmalloc(sizeof *a, GFP_KERNEL);
> 
> Generally, typedef structs are frowned upon in the kernel.  I'd prefer to 
> see this (and any others) changed to a normal type.

In this case, however, it makes it easier to compare back to the original
code.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/