linux-kernel - Re: [PATCH 2/9] mm: alloc_contig_freed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111017113919.3b7ac253.akpm@linux-foundation.org>
Date:	Mon, 17 Oct 2011 11:39:19 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Marek Szyprowski <m.szyprowski@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-media@...r.kernel.org, linux-mm@...ck.org,
	linaro-mm-sig@...ts.linaro.org,
	"'Michal Nazarewicz'" <mina86@...a86.com>,
	"'Kyungmin Park'" <kyungmin.park@...sung.com>,
	"'Russell King'" <linux@....linux.org.uk>,
	"'KAMEZAWA Hiroyuki'" <kamezawa.hiroyu@...fujitsu.com>,
	"'Ankita Garg'" <ankita@...ibm.com>,
	"'Daniel Walker'" <dwalker@...eaurora.org>,
	"'Mel Gorman'" <mel@....ul.ie>, "'Arnd Bergmann'" <arnd@...db.de>,
	"'Jesse Barker'" <jesse.barker@...aro.org>,
	"'Jonathan Corbet'" <corbet@....net>,
	"'Shariq Hasnain'" <shariq.hasnain@...aro.org>,
	"'Chunsang Jeong'" <chunsang.jeong@...aro.org>,
	"'Dave Hansen'" <dave@...ux.vnet.ibm.com>
Subject: Re: [PATCH 2/9] mm: alloc_contig_freed_pages() added

On Mon, 17 Oct 2011 14:21:07 +0200
Marek Szyprowski <m.szyprowski@...sung.com> wrote:

> > > +
> > > +void free_contig_pages(unsigned long pfn, unsigned nr_pages)
> > > +{
> > > +	struct page *page = pfn_to_page(pfn);
> > > +
> > > +	while (nr_pages--) {
> > > +		__free_page(page);
> > > +		++pfn;
> > > +		if (likely(zone_pfn_same_memmap(pfn - 1, pfn)))
> > > +			++page;
> > > +		else
> > > +			page = pfn_to_page(pfn);
> > > +	}
> > > +}
> > 
> > You're sure these functions don't need EXPORT_SYMBOL()?  Maybe the
> > design is that only DMA core calls into here (if so, that's good).
> 
> Drivers should not call it, it is intended to be used by low-level DMA
> code.

OK, thanks for checking.

> Do you think that a comment about missing EXPORT_SYMBOL is 
> required?

No.  If someone later wants to use these from a module then we can look
at their reasons and make a decision at that time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/