linux-kernel - Re: [PATCH] timekeeping: fix bogus comment in timekeeping_get_ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1318878581.3125.81.camel@work-vm>
Date:	Mon, 17 Oct 2011 12:09:41 -0700
From:	john stultz <johnstul@...ibm.com>
To:	Dan McGee <dpmcgee@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] timekeeping: fix bogus comment in
 timekeeping_get_ns_raw

On Mon, 2011-10-17 at 13:58 -0500, Dan McGee wrote:
> The whole point of this function is to return a value not touched by
> NTP; unfortunately the comment got copied wholesale without adjustment
> from the timekeeping_get_ns function above.
> 
> Signed-off-by: Dan McGee <dpmcgee@...il.com>
> ---
>  kernel/time/timekeeping.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index 2b021b0e..a5846a8 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -131,7 +131,7 @@ static inline s64 timekeeping_get_ns_raw(void)
>  	/* calculate the delta since the last update_wall_time: */
>  	cycle_delta = (cycle_now - clock->cycle_last) & clock->mask;
> 
> -	/* return delta convert to nanoseconds using ntp adjusted mult. */
> +	/* return delta convert to nanoseconds. */
>  	return clocksource_cyc2ns(cycle_delta, clock->mult, clock->shift);
>  }

Thanks for catching this! I'll apply it to my queue!
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/