linux-kernel - Re: [PATCH] drivers, vmw_balloon.c: Determine page allocation flag can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADZ9YHiurKJPiDjVzhcjGtfOGF2gNPNi5eC1snT0Tw5opBSM8w@mail.gmail.com>
Date:	Tue, 18 Oct 2011 02:10:38 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dmitry Torokhov <dtor@...are.com>
Subject: Re: [PATCH] drivers, vmw_balloon.c: Determine page allocation flag
 can_sleep outside loop.

On Tue, Oct 18, 2011 at 1:31 AM, David Rientjes <rientjes@...gle.com> wrote:
> On Tue, 18 Oct 2011, Rakib Mullick wrote:
>
>> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
>> index 053d36c..6983d80 100644
>> --- a/drivers/misc/vmw_balloon.c
>> +++ b/drivers/misc/vmw_balloon.c
>> @@ -412,6 +412,7 @@ static int vmballoon_reserve_page(struct vmballoon *b, bool can_sleep)
>>       gfp_t flags;
>>       unsigned int hv_status;
>>       bool locked = false;
>> +     flags = can_sleep ? VMW_PAGE_ALLOC_CANSLEEP : VMW_PAGE_ALLOC_NOSLEEP;
>>
>>       do {
>>               if (!can_sleep)
>
> Should be folded in with the declaration of gfp_t flags.
>
> Would you also like to add a might_sleep_if(can_sleep) here?
>
I'm not sure. But, I don't think it's needed here. can_sleep tells
whether alloc_page can sleep or not, which has been determined and
passed by the callee function.


Thanks,
Rakib
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/