linux-kernel - Re: [PATCH V1 1/2] Staging: comedi: fix printk issue in cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111017220631.GA26535@kroah.com>
Date:	Mon, 17 Oct 2011 15:06:31 -0700
From:	Greg KH <greg@...ah.com>
To:	Ravishankar Karkala Mallikarjunayya 
	<ravishankar.km@...enturtles.in>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V1 1/2] Staging: comedi: fix printk issue in cb_pcidda.c

On Mon, Oct 03, 2011 at 07:18:12PM +0530, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the cb_pcidda.c file that fixes up a printk warning found by the checkpatch.pl tool
> 
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@...enturtles.in>
> ---
> I was not mentioned  printk("eeprom:") and 
>  printk(" %i:0x%x ", index, devpriv->eeprom_data[index]); line in Earlier patch which is fixed.
> 
>  drivers/staging/comedi/drivers/cb_pcidda.c |   25 ++++++++++++++-----------
>  1 files changed, 14 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/cb_pcidda.c b/drivers/staging/comedi/drivers/cb_pcidda.c
> index 49102b3..da5b8e5 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidda.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidda.c
> @@ -282,7 +282,8 @@ static int cb_pcidda_attach(struct comedi_device *dev,
>  	struct pci_dev *pcidev = NULL;
>  	int index;
>  
> -	printk("comedi%d: cb_pcidda: ", dev->minor);
> +	dev_info(&pcidev->dev, "comedi%d: cb_pcidda:\n",
> +		dev->minor);
>  
>  /*
>   * Allocate the private structure area.
> @@ -293,7 +294,6 @@ static int cb_pcidda_attach(struct comedi_device *dev,
>  /*
>   * Probe the device to determine what device in the series it is.
>   */
> -	printk("\n");
>  
>  	for_each_pci_dev(pcidev) {
>  		if (pcidev->vendor == PCI_VENDOR_ID_CB) {
> @@ -312,22 +312,24 @@ static int cb_pcidda_attach(struct comedi_device *dev,
>  		}
>  	}
>  	if (!pcidev) {
> -		printk
> -		    ("Not a ComputerBoards/MeasurementComputing card on requested position\n");
> +		dev_err(&pcidev->dev, "Not a "
> +			"ComputerBoards/MeasurementComputing "
> +			"card on requested position\n");

Please don't break strings across lines like this, just put them all on
one line.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/