linux-kernel - Re: [patch] Avoid using hardcoded values in kernel/sys.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1110171832060.13515@chino.kir.corp.google.com>
Date:	Mon, 17 Oct 2011 18:33:10 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Henrik Grindal Bakken <henribak@...co.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] Avoid using hardcoded values in kernel/sys.c

On Mon, 17 Oct 2011, Linus Torvalds wrote:

> > The release field of struct new_utsname may always change, so avoid
> > hardcoded values when setting up a buffer to copy to it.
> 
> This patch is totally bogus.
> 
> > +static int override_release(char __user *release)
> >  {
> > +       const int len = sizeof(release);
> 

Right, I meant to pass the struct in and use sizeof(release->name), but I 
was under the impression that wouldn't count as a variable length array or 
be compiled as such by ISO99 standards because it's a constant expression 
(as the standard says is not variable length).