linux-kernel - Re: [PATCH 34/49] gma500: the GEM and GTT code is device independant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN_cFWNKQxKnfZGd8zxvL_Z6J9h59rp-K5pe5f=s65zWJw9K0Q@mail.gmail.com>
Date:	Tue, 18 Oct 2011 08:36:01 -0500
From:	Rob Clark <rob.clark@...aro.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Hugh Dickins <hughd@...gle.com>,
	Patrik Jakobsson <patrik.r.jakobsson@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>, greg@...ah.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 34/49] gma500: the GEM and GTT code is device independant

On Tue, Oct 18, 2011 at 7:08 AM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> On Tue, 18 Oct 2011 06:59:28 -0500
> Rob Clark <rob.clark@...aro.org> wrote:
>
>> On Tue, Oct 18, 2011 at 5:45 AM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
>> >> What troubles could you see for swap+uncached (or more likely,
>> >> writecombine) pages?
>> >
>> > That should never occur. I would argue the driver is responsible for
>> > putting the cache state of the page back sensibly before it unpins it.
>> > That's a simple enough rule and one I think all the drivers follow at
>> > this point.
>>
>> no, what I'm trying to avoid is having two virtual mappings to the
>> same physical page with different cache attributes.  This is not
>> allowed on some architectures (like ARM)
>
> Nor x86... that's a matter for the core architecture code to deal with
> not the drivers.
>

hmm, maybe I'm missing something, but how is this ensured on x86?
Default drm_gem_mmap() maps pages to userspace as writecombine..  but
if page comes from kernel linear map (not highmem), that will be a
cached kernel virtual mapping in addition to the wc userspace mapping.

BR,
-R

> Alan
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/