linux-kernel - RE: [PATCH v2] gpio/samsung: Complain loudly if we don't know the SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <00b601cc8d2a$20d20780$62761680$%kim@samsung.com>
Date:	Tue, 18 Oct 2011 09:08:55 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Mark Brown' <broonie@...nsource.wolfsonmicro.com>,
	'Grant Likely' <grant@...retlab.ca>
Cc:	linux-arm-kernel@...ts.infradead.org,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: RE: [PATCH v2] gpio/samsung: Complain loudly if we don't know the SoC

Mark Brown wrote:
> 
> If we don't know the SoC type then we won't add any chips which is rather
> unfortunate as neither GPIO nor pinmux APIs will work, breaking lots of
> different subsystems. Logging at least provides a hint to the user as to
> what's gone wrong.
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  drivers/gpio/gpio-samsung.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 479edc3..8662518 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -2486,6 +2486,9 @@ static __init int samsung_gpiolib_init(void)
>  		s5p_register_gpioint_bank(IRQ_GPIO_XA, 0,
> IRQ_GPIO1_NR_GROUPS);
>  		s5p_register_gpioint_bank(IRQ_GPIO_XB,
> IRQ_GPIO1_NR_GROUPS, IRQ_GPIO2_NR_GROUPS);
>  #endif
> +	} else {
> +		WARN(1, "Unknown SoC in gpio-samsung, no GPIOs added\n");
> +		return -ENODEV;
>  	}
> 
>  	return 0;
> --
> 1.7.6.3

Looks ok to me, applied.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/