linux-kernel - Re: [PATCHv3 6/7] input/cma3000_d0x: Unwind reverse order of init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPybu_3hT3aPNeFuy=cwj2bUp7wtsVAZq1KMnfgvKsT8zRgicA@mail.gmail.com>
Date:	Tue, 18 Oct 2011 19:10:01 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	sameo@...ux.intel.com, peter.ujfalusi@...com,
	aghayal@...eaurora.org, david@...deman.nu, Shubhrajyoti@...com,
	saaguirre@...com, jic23@....ac.uk, hemanthv@...com,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 6/7] input/cma3000_d0x: Unwind reverse order of init

Ok,

 I remove that patch and fix it for the new cmr3000 driver


    Thanks!

On Tue, Oct 18, 2011 at 19:03, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> On Tuesday, October 18, 2011 09:57:24 AM Ricardo Ribalda Delgado wrote:
>> Hello Dmitry
>>
>>  You are right, and also could be a good idea to init the irq, only
>> after the input device has been registered. Dont you think so?
>
> Input core is constructed in such way that it is safe to call
> input_report_*() and input_event() on properly allocated input device,
> even if it has not been registered yet, the events will simply be
> dropped.
>
> So no, it is not necessary and doing so is quite often complicates
> error handling in probe() routines.
>
> Thanks.
>
> --
> Dmitry
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/