linux-kernel - Re: [PATCH -V7 25/26] ext4: Implement rich acl for ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <BCAE5666-30A1-484A-9808-B52E5B422A3F@dilger.ca>
Date:	Tue, 18 Oct 2011 12:41:15 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	agruen@...nel.org, bfields@...ldses.org, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk, dhowells@...hat.com,
	linux-fsdevel@...r.kernel.org, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -V7 25/26] ext4: Implement rich acl for ext4

On 2011-10-18, at 9:33 AM, Aneesh Kumar K.V wrote:
> From: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
> 
> Support the richacl permission model in ext4.  The richacls are stored
> in "system.richacl" xattrs.This need to be enabled by tune2fs or during
> mkfs.ext4

It isn't clear from your commit comment or the code what needs to be enabled by tune2fs or mkfs.ext4.  Please list the specific ext4 feature
that needs to be enabled.

> +#ifdef CONFIG_EXT4_FS_RICHACL
> +#define EXT4_IS_RICHACL(inode) IS_RICHACL(inode)
> 

> +#else  /* CONFIG_FS_EXT4_RICHACL */
> +
> +#define EXT4_IS_RICHACL(inode) (0)

It is a bit confusing that you are using both EXT4_IS_RICHACL() and
IS_RICHACL() in this code.  Initially I thought EXT4_IS_RICHACL() was
checking an ext4-specific inode flag, but it seems that it is instead
conditional upon the configure flags.

It looks like it should be possible to use EXT4_IS_RICHACL() in all
of the code, since the richacl-specific code will not be compiled
anyway.

Cheers, Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/