linux-kernel - Re: [PATCH] Smack: fix: invalid length set for the result of /smack/access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E9DCE6B.9060006@schaufler-ca.com>
Date:	Tue, 18 Oct 2011 12:07:23 -0700
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	Jarkko Sakkinen <jarkko.j.sakkinen@...il.com>
CC:	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	James Morris <jmorris@...ei.org>
Subject: Re: [PATCH] Smack: fix: invalid length set for the result of /smack/access

On 10/18/2011 4:34 AM, Jarkko Sakkinen wrote:
> Forgot to update simple_transaction_set() to take terminator
> character into account.
>
> Signed-off-by: Jarkko Sakkinen <jarkko.j.sakkinen@...il.com>

Applied to git://gitorious.org/smack-next/kernel.git#master
commit d86b2b61d4dea614d6f319772a90a8f98b55ed67


> ---
>  security/smack/smackfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 5498c4a..381eecf 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -1514,7 +1514,7 @@ static ssize_t smk_write_access(struct file *file, const char __user *buf,
>  	data[0] = res == 0 ? '1' : '0';
>  	data[1] = '\0';
>  
> -	simple_transaction_set(file, 1);
> +	simple_transaction_set(file, 2);
>  	return SMK_LOADLEN;
>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/