linux-kernel - Re: [PATCH 1/2] x86, microcode: Correct microcode revision format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1110172349590.8959@chino.kir.corp.google.com>
Date:	Mon, 17 Oct 2011 23:50:27 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Borislav Petkov <bp@...64.org>
cc:	Ingo Molnar <mingo@...e.hu>, X86-ML <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <borislav.petkov@....com>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 1/2] x86, microcode: Correct microcode revision format

On Mon, 17 Oct 2011, Borislav Petkov wrote:

> diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
> index 8af6fa4..ad8d897 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce.c
> @@ -221,7 +221,7 @@ static void print_mce(struct mce *m)
>  	 * Note this output is parsed by external tools and old fields
>  	 * should not be changed.
>  	 */
> -	pr_emerg(HW_ERR "PROCESSOR %u:%x TIME %llu SOCKET %u APIC %x microcode %u\n",
> +	pr_emerg(HW_ERR "PROCESSOR %u:%x TIME %llu SOCKET %u APIC %x microcode %x\n",
>  		m->cpuvendor, m->cpuid, m->time, m->socketid, m->apicid,
>  		cpu_data(m->extcpu).microcode);
>  

Any reason why this isn't prefixed with "0x"?

> diff --git a/arch/x86/kernel/cpu/proc.c b/arch/x86/kernel/cpu/proc.c
> index 6254fda..14b2314 100644
> --- a/arch/x86/kernel/cpu/proc.c
> +++ b/arch/x86/kernel/cpu/proc.c
> @@ -86,7 +86,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
>  	else
>  		seq_printf(m, "stepping\t: unknown\n");
>  	if (c->microcode)
> -		seq_printf(m, "microcode\t: %u\n", c->microcode);
> +		seq_printf(m, "microcode\t: 0x%x\n", c->microcode);
>  
>  	if (cpu_has(c, X86_FEATURE_TSC)) {
>  		unsigned int freq = cpufreq_quick_get(cpu);

When here it is?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/