linux-kernel - Re: checkpatch WARNING: patch prefix 'b' exists, appears to be a -p0 patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1318982469.7569.1.camel@Joe-Laptop>
Date:	Tue, 18 Oct 2011 17:01:09 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Rientjes <rientjes@...gle.com>,
	Wolfram Sang <w.sang@...gutronix.de>
Cc:	Jonathan Cameron <jic23@....ac.uk>,
	Andy Whitcroft <apw@...onical.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: checkpatch WARNING: patch prefix 'b' exists, appears to be a
 -p0 patch

On Tue, 2011-10-18 at 16:44 -0700, David Rientjes wrote:
> On Tue, 18 Oct 2011, Jonathan Cameron wrote:
> > This started happening when I run checkpatch on pretty much anything.
> > triggered by the b in this snipped for example
> > diff --git a/arch/arm/mach-pxa/stargate2.c b/arch/arm/mach-pxa/stargate2.c
> > index 3f8d0af..62dc2a8 100644
> > --- a/arch/arm/mach-pxa/stargate2.c
> > +++ b/arch/arm/mach-pxa/stargate2.c
> > @@ -54,6 +54,8 @@
> >  #include <linux/mfd/da903x.h>
> > Anyone else seeing this or have a clue what the heck is going on?

It's done this since:

$ git log -1 1e85572697b348b1a126520349a29654f2ae6a12
commit 1e85572697b348b1a126520349a29654f2ae6a12
Author: Wolfram Sang <w.sang@...gutronix.de>
Date:   Tue Jan 6 14:41:24 2009 -0800

    checkpatch: Add warning for p0-patches
    
    Some people work internally with -p0-patches which has the danger that one
    forgets to convert them to -p1 before mainlining.  Bitten myself and seen
    p0-patches in mailing lists occasionally, this patch adds a warning to
    checkpatch.pl in case a patch is -p0.  If you really want, you can fool
    this check to generate false positives, this is why it just spits a
    warning.  Making the check 100% proof is trickier than it looks, so let's
    start with a version which catches the cases of real use.
    
    [apw@...onical.com: update message language, handle null prefix, add tests]
    Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
    Signed-off-by: Andy Whitcroft <apw@...onical.com>
    Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>

I've always ignored it.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/