linux-kernel - Re: [PATCH 1/2] ASoC: sgtl5000: Fix define for SGTL5000_BIAS_R

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABS+qY2n2xXVvK=CqOPXfH2YOYijPwSAc7tH=CYL1AJXGPxBNQ@mail.gmail.com>
Date:	Wed, 19 Oct 2011 09:06:57 +0100
From:	"Girdwood, Liam" <lrg@...com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Zeng Zhaoming <zhaoming.zeng@...escale.com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH 1/2] ASoC: sgtl5000: Fix define for SGTL5000_BIAS_R_MASK

On 19 October 2011 03:54, Axel Lin <axel.lin@...il.com> wrote:
> According to the datasheet:
> CHIP_MIC_CTRL 0x002A
>
> BITS[9:8] BIAS_RESISTOR
>        0x0 = Powerd off
>        0x1 = 2.0 kohm
>        0x2 = 4.0 kohm
>        0x3 = 8.0 kohm
>
> Thus SGTL5000_BIAS_R_MASK should be defined as 0x0300 instead of 0x0200.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  sound/soc/codecs/sgtl5000.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h
> index eec3ab3..8a9f435 100644
> --- a/sound/soc/codecs/sgtl5000.h
> +++ b/sound/soc/codecs/sgtl5000.h
> @@ -280,7 +280,7 @@
>  /*
>  * SGTL5000_CHIP_MIC_CTRL
>  */
> -#define SGTL5000_BIAS_R_MASK                   0x0200
> +#define SGTL5000_BIAS_R_MASK                   0x0300
>  #define SGTL5000_BIAS_R_SHIFT                  8
>  #define SGTL5000_BIAS_R_WIDTH                  2
>  #define SGTL5000_BIAS_R_off                    0x0
> --
> 1.7.5.4
>
>
>
>

Both

Acked-by: Liam Girdwood <lrg@...com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/