linux-kernel - Re: [alsa-devel] [PATCH v6 2/2] ASoC: da7210: Add support for ALC and Noise suppression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CABS+qY0FnFk4gomSAvgRiwrVr+WVvqe-pTbicf2pLDcJkN4JZw@mail.gmail.com>
Date:	Wed, 19 Oct 2011 17:43:38 +0100
From:	"Girdwood, Liam" <lrg@...com>
To:	Ashish Chavan <ashish.chavan@...tcummins.com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	alsa-devel <alsa-devel@...a-project.org>,
	David Dajun Chen <david.chen@...semi.com>,
	"kuninori.morimoto.gx" <kuninori.morimoto.gx@...esas.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH v6 2/2] ASoC: da7210: Add support for ALC and
 Noise suppression

On 19 October 2011 09:54, Ashish Chavan <ashish.chavan@...tcummins.com> wrote:
> This patch adds controls to set following ALC parameters,
>  - Max gain, Min gain, Noise gain, Attack rate, Release rate and delay
>
> It also adds a switch to enable/disable noise suppression.
>
> As per DA7210 data sheet, ALC and noise suppression can be enabled
> only if certain conditions are met. This condition checks are handled
> by simply using "_EXT" version of controls to capture change events.
>
> Signed-off-by: Ashish Chavan <ashish.chavan@...tcummins.com>
> Signed-off-by: David Dajun Chen <dchen@...semi.com>
> ---
> Changes since v5:
> - Changed error code from -EPERM to EINVAL
> - Used bit fields instead of magic numbers
>
> Changes since v1:
> - Reading from register instead of cache
> - Made debug message more specific about error
> - Changed "Gain" to "Volume" in names of ALC controls
> ---
>  sound/soc/codecs/da7210.c |  110 +++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 110 insertions(+), 0 deletions(-)
>

Acked-by: Liam Girdwood <lrg@...com>

Thanks

Liam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/