linux-kernel - Re: [PATCH 8/9] x86, RAS: Add attributes needed for HW injection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1110191402490.5687@chino.kir.corp.google.com>
Date:	Wed, 19 Oct 2011 14:03:43 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Borislav Petkov <bp@...64.org>
cc:	EDAC devel <linux-edac@...r.kernel.org>,
	Tony Luck <tony.luck@...el.com>, Ingo Molnar <mingo@...e.hu>,
	X86-ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <borislav.petkov@....com>
Subject: Re: [PATCH 8/9] x86, RAS: Add attributes needed for HW injection

On Wed, 19 Oct 2011, Borislav Petkov wrote:

> diff --git a/arch/x86/kernel/cpu/ras/amd/mce-inject.c b/arch/x86/kernel/cpu/ras/amd/mce-inject.c
> index 1b797bd..8646080 100644
> --- a/arch/x86/kernel/cpu/ras/amd/mce-inject.c
> +++ b/arch/x86/kernel/cpu/ras/amd/mce-inject.c
> @@ -77,6 +77,59 @@ static int toggle_hw_mce_inject(unsigned int cpu, bool enable)
>  }
>  
>  /*
> + * HW or SW injection
> + */
> +static int hw_inj_get(void *data, u64 *val)
> +{
> +	struct mce *m = (struct mce *)data;
> +
> +	*val = !!(m->inject_flags & MCJ_HW_MSR_INJECT);
> +
> +	return 0;
> +}
> +
> +static int hw_inj_set(void *data, u64 val)
> +{
> +	struct mce *m = (struct mce *)data;
> +
> +	switch (val) {
> +	case 0:
> +		m->inject_flags &= (u8)~MCJ_HW_MSR_INJECT;
> +		break;
> +
> +	case 1:
> +		m->inject_flags |= MCJ_HW_MSR_INJECT;
> +		break;
> +
> +	default:
> +		printk(KERN_ERR "%s: Only 0 or 1 allowed!\n", __func__);
> +		return -EINVAL;
> +	}
> +	return 0;
> +}
> +
> +DEFINE_SIMPLE_ATTRIBUTE(hw_inj_fops, hw_inj_get, hw_inj_set, "%llu\n");
> +
> +/*
> + * On which CPU to inject?
> + */
> +MCE_INJECT_GET(extcpu);
> +
> +static int inj_extcpu_set(void *data, u64 val)
> +{
> +	struct mce *m = (struct mce *)data;
> +
> +	if (val >= num_online_cpus()) {

That wouldn't catch an offline cpuid, you probably want cpu_online(val)?

> +		printk(KERN_ERR "%s: Non-existent CPU: %llu\n", __func__, val);
> +		return -EINVAL;
> +	}
> +	m->extcpu = val;
> +	return 0;
> +}
> +
> +DEFINE_SIMPLE_ATTRIBUTE(extcpu_fops, inj_extcpu_get, inj_extcpu_set, "%llu\n");
> +
> +/*
>   * This denotes into which bank we're injecting and triggers
>   * the injection, at the same time.
>   */
> @@ -116,6 +169,8 @@ struct dfs_node {
>  	{ .name = "misc",	.fops = &misc_fops },
>  	{ .name = "addr",	.fops = &addr_fops },
>  	{ .name = "bank",	.fops = &bank_fops },
> +	{ .name = "hw_inject",	.fops = &hw_inj_fops },
> +	{ .name = "cpu",	.fops = &extcpu_fops },
>  };
>  
>  static int __init init_mce_inject(void)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/