linux-kernel - Re: [PATCH 1/11] MFD: DA9052 MFD core module v8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111019223831.GA10573@opensource.wolfsonmicro.com>
Date:	Wed, 19 Oct 2011 23:38:32 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ashish Jangam <ashish.jangam@...tcummins.com>
Cc:	"arnd@...db.de" <arnd@...db.de>,
	"sameo@...nedhand.com" <sameo@...nedhand.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dajun <dajun.chen@...semi.com>,
	"linaro-dev@...ts.linaro.org" <linaro-dev@...ts.linaro.org>
Subject: Re: [PATCH 1/11] MFD: DA9052 MFD core module v8

On Wed, Oct 19, 2011 at 07:39:16PM +0530, Ashish Jangam wrote:

> +static struct regmap_config da9052_regmap_config = {
> +	.reg_bits = 8,
> +	.val_bits = 8,
> +};
> +
> +static int da9052_spi_probe(struct spi_device *spi)

So, as I think I mentioned last time based on the previous non-regmap
versions of the patch I don't expect this to work at all.  You should
use the read_mask and/or write_mask options to set the flag bits you
need to indicated if this is a read or write.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/