linux-kernel - Re: [PATCH 2/2] gpio-ml-ioh: Use NUMA_NO_NODE not GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111020010157.GB2153@ponder.secretlab.ca>
Date:	Wed, 19 Oct 2011 19:01:57 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Tomoya MORINAGA <tomoya-linux@....lapis-semi.com>
Cc:	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com, Dan Carpenter <dan.carpenter@...cle.com>,
	David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH 2/2] gpio-ml-ioh: Use NUMA_NO_NODE not GFP_KERNEL

On Wed, Oct 19, 2011 at 10:37:40AM +0900, Tomoya MORINAGA wrote:
> Currently, GFP_KERNEL is used as parameter of irq_alloc_descs like below.
> 
>           irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
>                                      GFP_KERNEL);
> 
> This is not true.
> So, this patch uses NUMA_NO_NODE not GFP_KERNEL.

Applied both, thanks.

g.

> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Reported-by: David Rientjes <rientjes@...gle.com>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@....lapis-semi.com>
> ---
>  drivers/gpio/gpio-ml-ioh.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
> index 88d65be..1b59003 100644
> --- a/drivers/gpio/gpio-ml-ioh.c
> +++ b/drivers/gpio/gpio-ml-ioh.c
> @@ -429,7 +429,7 @@ static int __devinit ioh_gpio_probe(struct pci_dev *pdev,
>  	chip = chip_save;
>  	for (j = 0; j < 8; j++, chip++) {
>  		irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
> -					   GFP_KERNEL);
> +					   NUMA_NO_NODE);
>  		if (irq_base < 0) {
>  			dev_warn(&pdev->dev,
>  				"ml_ioh_gpio: Failed to get IRQ base num\n");
> -- 
> 1.7.4.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/