linux-kernel - Re: [PATCH 4/4] pinctrl: Don't copy function name when requesting a pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdae_DWEMQc+NOT1oX4XXKFzjXg3uiHihXMHr+ztPPAQdg@mail.gmail.com>
Date:	Thu, 20 Oct 2011 11:48:56 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Stephen Warren <swarren@...dia.com>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, Barry Song <21cnbao@...il.com>,
	Shawn Guo <shawn.guo@...escale.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	David Brown <davidb@...eaurora.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rongjun Ying <Rongjun.Ying@....com>,
	Linaro Dev <linaro-dev@...ts.linaro.org>
Subject: Re: [PATCH 4/4] pinctrl: Don't copy function name when requesting a pin

On Thu, Oct 20, 2011 at 12:19 AM, Stephen Warren <swarren@...dia.com> wrote:

> Instead, store a pointer to the currently assigned function.
>
> This allows us to delete the mux_requested variable from pin_desc; a pin
> is requested if its currently assigned function is non-NULL.
>
> When a pin is requested as a GPIO rather than a regular function, the
> assigned function name is dynamically constructed. In this case, we have
> to kstrdup() the dynamically constructed name, so that mux_function doesn't
> pointed at stack data. This requires pin_free to be told whether to free
> the mux_function pointer or not.
>
> This removes the hard-coded maximum function name length.
>
> Signed-off-by: Stephen Warren <swarren@...dia.com>

Thanks, applied.
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/