linux-kernel - RE: iwlagn is getting very shaky

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E9954878DD1FB34FAE5187FB88C58A3501A0D0992E@orsmsx506.amr.corp.intel.com>
Date:	Wed, 19 Oct 2011 19:55:28 -0700
From:	"Guy, Wey-Yi W" <wey-yi.w.guy@...el.com>
To:	Norbert Preining <preining@...ic.at>
CC:	David Rientjes <rientjes@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ipw3945-devel@...ts.sourceforge.net" 
	<ipw3945-devel@...ts.sourceforge.net>,
	"ilw@...ux.intel.com" <ilw@...ux.intel.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: RE: iwlagn is getting very shaky

Hmm, I am sure I have the attachment, but here I attach again.

Also, the patch is simple. Only few lines

>From 78e955b90a8e259d180bfb962ef4558645d74a91 Mon Sep 17 00:00:00 2001
From: Wey-Yi Guy <wey-yi.w.guy@...el.com>
Date: Wed, 19 Oct 2011 18:27:41 -0700
Subject: [PATCH 1/1] iwlagn: stop queue testing

Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@...el.com>
---
 drivers/net/wireless/iwlwifi/iwl-agn-lib.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
index 3bee0f1..d543686 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
@@ -191,8 +191,14 @@ static void iwlagn_set_tx_status(struct iwl_priv *priv,
 	if (status == TX_STATUS_FAIL_PASSIVE_NO_RX &&
 	    iwl_is_associated_ctx(ctx) && ctx->vif &&
 	    ctx->vif->type == NL80211_IFTYPE_STATION) {
+#if 0
 		ctx->last_tx_rejected = true;
 		iwl_stop_queue(priv, &priv->txq[txq_id]);
+#endif
+IWL_ERR(priv,
+       "Encounter TX_STATUS_FAIL_PASSIVE_NO_RX, am I on 5.2G band? (%d)\n",
+       txq_id);
+
 	}
 
 	IWL_DEBUG_TX_REPLY(priv, "TXQ %d status %s (0x%08x) rate_n_flags "
-- 
1.7.0.4

Thanks
Wey
-----Original Message-----
From: Norbert Preining [mailto:preining@...ic.at] 
Sent: Wednesday, October 19, 2011 7:51 PM
To: Guy, Wey-Yi W
Cc: David Rientjes; linux-kernel@...r.kernel.org; ipw3945-devel@...ts.sourceforge.net; ilw@...ux.intel.com; linux-wireless@...r.kernel.org; Pekka Enberg
Subject: Re: iwlagn is getting very shaky

On Mi, 19 Okt 2011, Guy, Wey-Yi wrote:
> > Do you mean the patch you send with a strange date:
...

> > It does not apply at all, I cannot even find
> > 	rejected
> > in iwl-agn-tx.c.
> > 
> > On which tree is that based, can you provide a patch against main 
> > git branch of Linus.
> > 
> > Thanks.
> > 
> Let's try this and see if apply. btw, are you on 5GHz?

Which one??? Nothing attached, nothing received, and the patch you sent before does not apply .... not even with manual intervention ... at least I am not able.

5GHz: I don't know by now, not at university by now.

Best wishes

Norbert
------------------------------------------------------------------------
Norbert Preining            preining@...ist.ac.jp, logic.at, debian.org}
JAIST, Japan                                 TeX Live & Debian Developer
DSA: 0x09C5B094   fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
------------------------------------------------------------------------
`Ford, you're turning into a penguin. Stop it.'
                 --- Arthur experiences the improbability drive at work.
                 --- Douglas Adams, The Hitchhikers Guide to the Galaxy

Download attachment "0001-iwlagn-stop-queue-testing.patch" of type "application/octet-stream" (1140 bytes)