linux-kernel - Re: [PATCH 02/10] block: fix genhd refcounting in blkio_policy_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111020175022.GD13685@redhat.com>
Date:	Thu, 20 Oct 2011 13:50:22 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Tejun Heo <tj@...nel.org>, axboe@...nel.dk,
	linux-kernel@...r.kernel.org, ctalbott@...gle.com, rni@...gle.com,
	containers@...ts.linux-foundation.org
Subject: Re: [PATCH 02/10] block: fix genhd refcounting in
 blkio_policy_parse_and_set()

On Thu, Oct 20, 2011 at 06:16:04PM +0200, Kay Sievers wrote:
> On Thu, Oct 20, 2011 at 18:11, Tejun Heo <tj@...nel.org> wrote:
> > I think this is essentially a bug.  If you have something like "dev =
> > find_and_get(); put(dev); return dev != NULL;", it's a pretty good
> > indication something is pretty screwed there, so unless someone
> > screams really loud, I think I'm gonna push for removal of the
> > feature.
> 
> Matching on unpredictable dev_t inside the kernel or in userspace is a
> serious bug. We can't do anything like that ever on a modern system,
> these times are long over.
> 
> Yes, please get rid of this misguided logic, nobody should get the
> impression that this can ever work.

Kay,

So are you suggesting don't use device major/minor number for specifying
the rules in cgroup or you are suggesting the same thing as Tejun that
automatically get rid of rule when device goes away. 

If it is former, then what else one can use for specifying the rule.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/