linux-kernel - [PATCH] fs: grow_dev_page() failure path not a BUG()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1319148356-15063-1-git-send-email-lhuemill@google.com>
Date:	Thu, 20 Oct 2011 15:05:56 -0700
From:	Louis Huemiller <lhuemill@...gle.com>
To:	Alexander Viro <viro@...iv.linux.org.uk>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Louis Huemiller <lhuemill@...gle.com>
Subject: [PATCH] fs: grow_dev_page() failure path not a BUG()

The function grow_dev_page() contains a label named failed which
is jumped to on allocation failure.  When the system is low on
memory, which is not a bug, this path can be taken.  This patch
removes the BUG() call, so that this path can be exercised for
proper operation on a debug kernel, without panicing the system.

Signed-off-by: Louis Huemiller <lhuemill@...gle.com>
---
 fs/buffer.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/buffer.c b/fs/buffer.c
index 1a80b04..04781e6 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1032,7 +1032,6 @@ grow_dev_page(struct block_device *bdev, sector_t block,
 	return page;
 
 failed:
-	BUG();
 	unlock_page(page);
 	page_cache_release(page);
 	return NULL;
-- 
1.7.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/