[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20111021085838.GE3513@opensource.wolfsonmicro.com>
Date: Fri, 21 Oct 2011 09:58:38 +0100
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@...tcummins.com>
Cc: lrg <lrg@...com>, alsa-devel <alsa-devel@...a-project.org>,
David Dajun Chen <david.chen@...semi.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@...esas.com>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
On Thu, Oct 20, 2011 at 07:32:49PM +0530, Ashish Chavan wrote:
> This patch adds support for DAPM covering all inputs and outputs
> as well as ADC and DAC.
This patch doesn't apply against current code.
> +/*
> + * DAPM Controls
> + *
> + * Current DAPM implementation covers almost all codec components e.g. IOs,
> + * mixers, PGAs,ADC and DAC.
This explanation would better placed next to the code in the probe -
it's that code which looks out of place in a Linux driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists