linux-kernel - Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20111021102350.GA4080@opensource.wolfsonmicro.com>
Date:	Fri, 21 Oct 2011 11:23:50 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ashish Chavan <ashish.chavan@...tcummins.com>
Cc:	lrg <lrg@...com>, alsa-devel <alsa-devel@...a-project.org>,
	David Dajun Chen <david.chen@...semi.com>,
	"kuninori.morimoto.gx" <kuninori.morimoto.gx@...esas.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM

On Fri, Oct 21, 2011 at 03:17:26PM +0530, Ashish Chavan wrote:
> On Fri, 2011-10-21 at 09:58 +0100, Mark Brown wrote:

> > This explanation would better placed next to the code in the probe -
> > it's that code which looks out of place in a Linux driver.

> Only problem with that is the code to enable individual IOs is not at
> one place and is scattered in the probe(). Should I place all such
> things in a single block in probe() and put the comment above that?

That sounds like a good idea - it's fine to split them up per feature
being enabled but if the big comment is in front of all of them that'd
be really helpful.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/