linux-kernel - Re: [PATCH 48/49] USB: pxa168: xls: irq: Remove IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EA2C233.4080500@einfochips.com>
Date:	Sat, 22 Oct 2011 18:46:35 +0530
From:	Tanmay Upadhyay <tanmay.upadhyay@...fochips.com>
To:	Yong Zhang <yong.zhang0@...il.com>
CC:	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	Jayachandran C <jayachandranc@...logicmicro.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 48/49] USB: pxa168: xls: irq: Remove IRQF_DISABLED


On Saturday 22 October 2011 03:27 PM, Yong Zhang wrote:
> Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
> We run all interrupt handlers with interrupts disabled
> and we even check and yell when an interrupt handler
> returns with interrupts enabled (see commit [b738a50a:
> genirq: Warn when handler enables interrupts]).
>
> So now this flag is a NOOP and can be removed.
>
> Signed-off-by: Yong Zhang<yong.zhang0@...il.com>

Acked-by: Tanmay Upadhyay<tanmay.upadhyay@...fochips.com>

Thanks for updating USB driver for PXA168!

Thanks,

Tanmay


> Cc: Tanmay Upadhyay<tanmay.upadhyay@...fochips.com>
> Cc: Jayachandran C<jayachandranc@...logicmicro.com>
> Cc: Greg Kroah-Hartman<gregkh@...e.de>
> ---
>   drivers/usb/host/ehci-pxa168.c |    2 +-
>   drivers/usb/host/ohci-xls.c    |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-pxa168.c b/drivers/usb/host/ehci-pxa168.c
> index ac0c16e..f0b776d 100644
> --- a/drivers/usb/host/ehci-pxa168.c
> +++ b/drivers/usb/host/ehci-pxa168.c
> @@ -304,7 +304,7 @@ static int __devinit ehci_pxa168_drv_probe(struct platform_device *pdev)
>   	hcd->has_tt = 1;
>   	ehci->sbrn = 0x20;
>
> -	err = usb_add_hcd(hcd, irq, IRQF_SHARED | IRQF_DISABLED);
> +	err = usb_add_hcd(hcd, irq, IRQF_SHARED);
>   	if (err)
>   		goto err5;
>
> diff --git a/drivers/usb/host/ohci-xls.c b/drivers/usb/host/ohci-xls.c
> index a3a9c6f..38b6bda 100644
> --- a/drivers/usb/host/ohci-xls.c
> +++ b/drivers/usb/host/ohci-xls.c
> @@ -56,7 +56,7 @@ static int ohci_xls_probe_internal(const struct hc_driver *driver,
>   		goto err3;
>   	}
>
> -	retval = usb_add_hcd(hcd, irq, IRQF_DISABLED | IRQF_SHARED);
> +	retval = usb_add_hcd(hcd, irq, IRQF_SHARED);
>   	if (retval != 0)
>   		goto err4;
>   	return retval;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/