linux-kernel - Re: [PATCH] kbuild: fix set but not used warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACqU3MXS6-uE01EVAW1KdCViKioSz_F79YqzYwdTLrmc8hoMAw@mail.gmail.com>
Date:	Sat, 22 Oct 2011 15:30:49 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	Peter Foley <pefoley2@...izon.net>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Kbuild Mailing List <linux-kbuild@...r.kernel.org>,
	mmarek@...e.cz
Subject: Re: [PATCH] kbuild: fix set but not used warnings

Hi,

On Sat, Oct 22, 2011 at 2:01 PM, Peter Foley <pefoley2@...izon.net> wrote:
> Remove set but not used variables to fix warnings.
>
>  HOSTCC  scripts/kconfig/gconf.o
> /usr/src/lto/scripts/kconfig/gconf.c: In function 'change_sym_value':
> /usr/src/lto/scripts/kconfig/gconf.c:833:11: warning: variable 'oldval' set but not used [-Wunused-but-set-variable]
> /usr/src/lto/scripts/kconfig/gconf.c: In function 'update_tree':
> /usr/src/lto/scripts/kconfig/gconf.c:1281:19: warning: variable 'prop' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Peter Foley <pefoley2@...izon.net>
>
s/kbuild/kconfig/ in the subject, that help to know changes is only
limited to scripts/kconfig/

 - Arnaud

> ---
>  scripts/kconfig/gconf.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index b9e26a5..adc2306 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -830,7 +830,7 @@ static void renderer_edited(GtkCellRendererText * cell,
>  static void change_sym_value(struct menu *menu, gint col)
>  {
>        struct symbol *sym = menu->sym;
> -       tristate oldval, newval;
> +       tristate newval;
>
>        if (!sym)
>                return;
> @@ -847,7 +847,6 @@ static void change_sym_value(struct menu *menu, gint col)
>        switch (sym_get_type(sym)) {
>        case S_BOOLEAN:
>        case S_TRISTATE:
> -               oldval = sym_get_tristate_value(sym);
>                if (!sym_tristate_within_range(sym, newval))
>                        newval = yes;
>                sym_set_tristate_value(sym, newval);
> @@ -1278,7 +1277,6 @@ static void update_tree(struct menu *src, GtkTreeIter * dst)
>        gboolean valid;
>        GtkTreeIter *sibling;
>        struct symbol *sym;
> -       struct property *prop;
>        struct menu *menu1, *menu2;
>
>        if (src == &rootmenu)
> @@ -1287,7 +1285,6 @@ static void update_tree(struct menu *src, GtkTreeIter * dst)
>        valid = gtk_tree_model_iter_children(model2, child2, dst);
>        for (child1 = src->list; child1; child1 = child1->next) {
>
> -               prop = child1->prompt;
>                sym = child1->sym;
>
>              reparse:
> --
> 1.7.7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/