linux-kernel - Re: [DRM] Lower the severity of the radeon lockup messages.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Oct 2011 01:17:13 -0600
From:	Robert Hancock <hancockrwd@...il.com>
To:	Dave Jones <davej@...hat.com>, airlied@...hat.com,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [DRM] Lower the severity of the radeon lockup messages.

On 10/21/2011 10:51 AM, Dave Jones wrote:
> abrt files a lot of bug reports when users get GPU lockups, but there's not really
> enough context to do anything useful with them.  Given the lack of GPU context being
> dumped, this patch removes the stack trace, so that abrt ignores the messages.
>
> Signed-off-by: Dave Jones<davej@...hat.com>
>
> diff --git a/drivers/gpu/drm/radeon/radeon_fence.c b/drivers/gpu/drm/radeon/radeon_fence.c
> index 7fd4e3e..a488b50 100644
> --- a/drivers/gpu/drm/radeon/radeon_fence.c
> +++ b/drivers/gpu/drm/radeon/radeon_fence.c
> @@ -263,7 +263,7 @@ retry:
>   		 */
>   		if (seq == rdev->fence_drv.last_seq&&  radeon_gpu_is_lockup(rdev)) {
>   			/* good news we believe it's a lockup */
> -			WARN(1, "GPU lockup (waiting for 0x%08X last fence id 0x%08X)\n",
> +			printk(KERN_WARNING "GPU lockup (waiting for 0x%08X last fence id 0x%08X)\n",
>   			     fence->seq, seq);
>   			/* FIXME: what should we do ? marking everyone
>   			 * as signaled for now

At the risk of sounding obvious, wouldn't it be better to enhance the 
driver to dump out more useful debugging info in this case rather than 
just suppressing the ABRT report?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/