linux-kernel - Re: [PATCH] vfs - fix automount should ignore LOOKUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1319369629.7876.6.camel@perseus.themaw.net>
Date:	Sun, 23 Oct 2011 19:33:49 +0800
From:	Ian Kent <raven@...maw.net>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] vfs - fix automount should ignore LOOKUP_FOLLOW

On Sun, 2011-10-23 at 06:41 +0200, Miklos Szeredi wrote:
> On Sat, Oct 22, 2011 at 10:01 AM, Ian Kent <raven@...maw.net> wrote:
> > The recent patch by Miklos Szeredi that was meant to restore the original
> > behavior of not triggering automounts on stat(2) and other symlink following
> > syscalls also eliminated the unconditional triggering of automounts for
> > intermediate path components by eliminating the LOOKUP_CONTUNUE flag from
> > the check in fs/namei.c:follow_automount().
> >
> > This introduces a regression itself because it alters the original behaviour
> > which was to unconditionally automount on intermediate path components.
> 
> LOOKUP_CONTINUE flag no longer exists (commit 49084c3 "kill LOOKUP_CONTINUE")

Oh .. right, now I think about it I did see that commit, opps!

> 
> So this patch makes no sense for HEAD, it may make sense for backports.

Yeah, I was a bit to hasty trying to solve my own backport mistake.

> 
> Miklos
> 
> >
> > Signed-off-by: Ian Kent <raven@...maw.net>
> > ---
> >
> >  fs/namei.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/namei.c b/fs/namei.c
> > index 0b3138d..e4eee7c 100644
> > --- a/fs/namei.c
> > +++ b/fs/namei.c
> > @@ -732,7 +732,7 @@ static int follow_automount(struct path *path, unsigned flags,
> >         * as being automount points.  These will need the attentions
> >         * of the daemon to instantiate them before they can be used.
> >         */
> > -       if (!(flags & (LOOKUP_PARENT | LOOKUP_DIRECTORY |
> > +       if (!(flags & (LOOKUP_PARENT | LOOKUP_CONTINUE | LOOKUP_DIRECTORY |
> >                     LOOKUP_OPEN | LOOKUP_CREATE | LOOKUP_AUTOMOUNT)) &&
> >            path->dentry->d_inode)
> >                return -EISDIR;
> >
> >


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/