linux-kernel - Re: kernel.org tarball/patch signature files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111023113727.GA24285@kroah.com>
Date:	Sun, 23 Oct 2011 13:37:27 +0200
From:	Greg KH <greg@...ah.com>
To:	Jari Ruusu <jariruusu@...rs.sourceforge.net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: kernel.org tarball/patch signature files

On Sun, Oct 23, 2011 at 02:17:20PM +0300, Jari Ruusu wrote:
> I noticed that patch-3.0.7.sign is a detached signature file for
> DECOMPRESSED patch-3.0.7.{bz2,gz,xz}.

That's exactly what I said in my announcement:
	https://lkml.org/lkml/2011/10/23/51
so I'm glad it's working properly :)

> Maybe this is not the best possible
> way to sign compressed tarballs/patches. This is because it places hell of
> lot of trust on quality/security of decompressor implementation.
> Historically decompressor implementations have had bugs and security flaws.
> It is stupid to assume that there won't be any more of them.
> 
> Wrong order to verify compressed tarball/patch:
> 
> (1) Feed potentially maliciously formatted data to decompressor, and exploit
>     any undiscovered/unpatched vulnerability in decompressor implementation.
> (2) Verify decompressed output.
> 
> Much better order would be:
> 
> (1) Verify compressed data.
> (2) Feed trusted data to decompressor.
> 
> So, would it be possible to have multiple signature files like this? Please.
> 
> patch-3.X.Y.bz2
> patch-3.X.Y.bz2.sign
> patch-3.X.Y.gz
> patch-3.X.Y.gz.sign
> patch-3.X.Y.xz
> patch-3.X.Y.xz.sign

Nope, sorry, let's try this way instead.  That way we only have to
generate one signature, not 3.

If you are really worried about decompressor bugs, then run them in a
virtual machine/chroot :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/