| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20111023115635.GA17912@n2100.arm.linux.org.uk> Date: Sun, 23 Oct 2011 12:56:35 +0100 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Catalin Marinas <catalin.marinas@....com> Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v7 08/16] ARM: LPAE: Page table maintenance for the 3-level format On Wed, Aug 10, 2011 at 04:03:31PM +0100, Catalin Marinas wrote: > This patch modifies the pgd/pmd/pte manipulation functions to support > the 3-level page table format. Since there is no need for an 'ext' > argument to cpu_set_pte_ext(), this patch conditionally defines a > different prototype for this function when CONFIG_ARM_LPAE. This has a really large number of ifdefs. You've split the 2 and 3 level page table stuff into two different header files already, conditionalized on CONFIG_ARM_LPAE, yet we still end up with lots of junk in the common header file conditionalized on that symbol. Can't we find a way to restructure pgtable.h to sort this out more cleanly? Do we really need to change the set_pte_ext() prototype as well - do we _really_ need ifdefs around its declaration, and every usage of it as well? Can't we just leave the 3rd argument as zero? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists