linux-kernel - Re: [PATCH 06/14] ARM : SAMSUNG : S3C2416 Added io mapping for Static memory controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 23 Oct 2011 11:44:57 -0500
From:	Paul Schilling <paul.s.schilling@...il.com>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Kukjin Kim <kgene.kim@...sung.com>,
	Russell King <linux@....linux.org.uk>,
	Yauhen Kharuzhy <yauhen.kharuzhy@...mwad.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/14] ARM : SAMSUNG : S3C2416 Added io mapping for Static
 memory controller.

Why did I add disabled code.  I didn't want to enable it if no one is
using it at the moment.
But,  I took me long enough to figure out how to enable the Static
memory Controller in the
MMU with out any hints to begin with.

Also the EBI portion is present in a vendor kernel version 2.6.21.

The Static Memory Controller peripheral needs to be set when ethernet
chips like the dm9000 is attached to the
samsung  ARM S3C2416.  The Boardcon board is a good example.

On Sat, Oct 22, 2011 at 4:43 PM, Heiko Stübner <heiko@...ech.de> wrote:
> Am Samstag 22 Oktober 2011, 06:21:41 schrieb Paul Schilling:
>> Added MMU access to the Static Memory Controller.
>>
>> Signed-off-by: Paul Schilling <paul.s.schilling@...il.com>
>> ---
>>  arch/arm/mach-s3c2416/s3c2416.c |   12 ++++++++++++
>>  1 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-s3c2416/s3c2416.c
>> b/arch/arm/mach-s3c2416/s3c2416.c index 494ce91..823a034 100644
>> --- a/arch/arm/mach-s3c2416/s3c2416.c
>> +++ b/arch/arm/mach-s3c2416/s3c2416.c
>> @@ -65,6 +65,18 @@ static struct map_desc s3c2416_iodesc[] __initdata = {
>>       IODESC_ENT(WATCHDOG),
>>       IODESC_ENT(CLKPWR),
>>       IODESC_ENT(TIMER),
>> +     {
>> +             .virtual        = (u32)S3C2412_VA_SSMC,
>> +             .pfn            = __phys_to_pfn(S3C2412_PA_SSMC),
>> +             .length         = SZ_1M,
>> +             .type           = MT_DEVICE,
>> +     },
>> +     /*{
>> +             .virtual        = (u32)S3C2412_VA_EBI,
>> +             .pfn            = __phys_to_pfn(S3C2412_PA_EBI),
>> +             .length         = SZ_1M,
>> +             .type           = MT_DEVICE,
>> +     },*/
>>  };
> why are you adding disabled code?
>
> Btw. it seems your posts got mangled somehow... only your patches 2,5 and 6 of
> 14 made it to linux-kernel and linux-arm-kernel.
>
> Heiko
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/