linux-kernel - Re: [PATCH v2 1/2] irq: Add EXPORT_SYMBOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111024132319.GU8708@ponder.secretlab.ca>
Date:	Mon, 24 Oct 2011 15:23:19 +0200
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org, mingo@...nel.org
Subject: Re: [PATCH v2 1/2] irq: Add EXPORT_SYMBOL_GPL to function of irq
 generic-chip

On Mon, Oct 17, 2011 at 11:08:46AM +0900, Nobuhiro Iwamatsu wrote:
> Some functions of irq generic-chip is undefined, because
> EXPORT_SYMBOL_GPL is not set to these.
> 
> -----
> ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
> ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
> ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
> ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
> -----
> 
> This is revised that EXPORT_SYMBOL_GPL can be added and referred
> to in functions.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>

After getting verbal ack from Thomas, I've merged this via the gpio tree.

g.

> ---
> 
> V2: Add EXPORT_SYMBOL_GPL to irq_setup_generic_chip, irq_alloc_generic_chip,
> irq_setup_alt_chip and irq_remove_generic_chip only.
> 
>  kernel/irq/generic-chip.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c
> index e38544d..6cb7613 100644
> --- a/kernel/irq/generic-chip.c
> +++ b/kernel/irq/generic-chip.c
> @@ -211,6 +211,7 @@ irq_alloc_generic_chip(const char *name, int num_ct, unsigned int irq_base,
>  	}
>  	return gc;
>  }
> +EXPORT_SYMBOL_GPL(irq_alloc_generic_chip);
>  
>  /*
>   * Separate lockdep class for interrupt chip which can nest irq_desc
> @@ -258,6 +259,7 @@ void irq_setup_generic_chip(struct irq_chip_generic *gc, u32 msk,
>  	}
>  	gc->irq_cnt = i - gc->irq_base;
>  }
> +EXPORT_SYMBOL_GPL(irq_setup_generic_chip);
>  
>  /**
>   * irq_setup_alt_chip - Switch to alternative chip
> @@ -281,6 +283,7 @@ int irq_setup_alt_chip(struct irq_data *d, unsigned int type)
>  	}
>  	return -EINVAL;
>  }
> +EXPORT_SYMBOL_GPL(irq_setup_alt_chip);
>  
>  /**
>   * irq_remove_generic_chip - Remove a chip
> @@ -311,6 +314,7 @@ void irq_remove_generic_chip(struct irq_chip_generic *gc, u32 msk,
>  		irq_modify_status(i, clr, set);
>  	}
>  }
> +EXPORT_SYMBOL_GPL(irq_remove_generic_chip);
>  
>  #ifdef CONFIG_PM
>  static int irq_gc_suspend(void)
> -- 
> 1.7.7
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/