linux-kernel - Re: [PATCH staging 3/6] et131x: fix error paths in et131x_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111024202116.GC3851@msilap.einon>
Date:	Mon, 24 Oct 2011 21:21:18 +0100
From:	Mark Einon <mark.einon@...il.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	Mark Einon <mark.einon@...il.com>, Greg KH <greg@...ah.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH staging 3/6] et131x: fix error paths in et131x_pci_setup.

On Sun, Oct 23, 2011 at 07:11:35PM +0200, Francois Romieu wrote:
> Wrong status code and unbalanced phy_connect.
> 
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> ---
[...]
> @@ -5448,9 +5424,11 @@ static int __devinit et131x_pci_setup(struct pci_dev *pdev,
>  	 */
>  	pci_set_drvdata(pdev, netdev);
>  	pci_save_state(adapter->pdev);
> +out:
> +	return rc;
>  
> -	return result;
> -
> +err_phy_disconnect:
> +	phy_disconnect(adapter->phydev);
>  err_mdio_unregister:
>  	mdiobus_unregister(adapter->mii_bus);
>  err_mdio_free_irq:
> @@ -5468,8 +5446,7 @@ err_release_res:
>  	pci_release_regions(pdev);
>  err_disable:
>  	pci_disable_device(pdev);
> -err_out:
> -	return result;
> +	goto out;
>  }
>  
>  static SIMPLE_DEV_PM_OPS(et131x_pm_ops, et131x_suspend, et131x_resume);

Patch looks good, but again, could you remove the backwards jumping goto.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/