linux-kernel - Re: [PATCH] h8300: Move gpio.h to gpio-internal.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111024221004.GE4394@ponder.secretlab.ca>
Date:	Tue, 25 Oct 2011 00:10:04 +0200
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Grant Likely <grant@...retlab.ca>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] h8300: Move gpio.h to gpio-internal.h

On Mon, Oct 24, 2011 at 11:59:21PM +0200, Mark Brown wrote:
> The current h8300 GPIO implementation doesn't provide the standard GPIO
> API, and in fact provides only direction control rather than normal GPIO
> functionality. Currently this is only used by the platform interrupt
> implementation rather than by a range of drivers so in preparation for
> moving over to gpiolib move the header out of the way of the gpiolib
> header, allowing a default GPIO implementation to be provided.
> 
> For actual use of these GPIOs with gpiolib a real driver would still need
> to be written but there appears to be no current need for this.
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

Acked-by: Grant Likely <grant.likely@...retlab.ca>

This of course should go via the h8300 tree instead of the gpio tree.

g.

> ---
> 
> It might be best to merge this via the gpiolib tree, partly because
> there appears to be little other activity on h8300 right now and partly
> to allow further refactoring.
> 
>  arch/h8300/include/asm/{gpio.h => gpio-internal.h} |    0
>  arch/h8300/platform/h8300h/irq.c                   |    2 +-
>  arch/h8300/platform/h8s/irq.c                      |    2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
>  rename arch/h8300/include/asm/{gpio.h => gpio-internal.h} (100%)
> 
> diff --git a/arch/h8300/include/asm/gpio.h b/arch/h8300/include/asm/gpio-internal.h
> similarity index 100%
> rename from arch/h8300/include/asm/gpio.h
> rename to arch/h8300/include/asm/gpio-internal.h
> diff --git a/arch/h8300/platform/h8300h/irq.c b/arch/h8300/platform/h8300h/irq.c
> index e977345..bc4f51b 100644
> --- a/arch/h8300/platform/h8300h/irq.c
> +++ b/arch/h8300/platform/h8300h/irq.c
> @@ -11,7 +11,7 @@
>  #include <asm/traps.h>
>  #include <asm/irq.h>
>  #include <asm/io.h>
> -#include <asm/gpio.h>
> +#include <asm/gpio-internal.h>
>  #include <asm/regs306x.h>
>  
>  const int __initdata h8300_saved_vectors[] = {
> diff --git a/arch/h8300/platform/h8s/irq.c b/arch/h8300/platform/h8s/irq.c
> index 8182f04..7b5f29f 100644
> --- a/arch/h8300/platform/h8s/irq.c
> +++ b/arch/h8300/platform/h8s/irq.c
> @@ -14,7 +14,7 @@
>  #include <asm/traps.h>
>  #include <asm/irq.h>
>  #include <asm/io.h>
> -#include <asm/gpio.h>
> +#include <asm/gpio-internal.h>
>  #include <asm/regs267x.h>
>  
>  /* saved vector list */
> -- 
> 1.7.6.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/