linux-kernel - Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvyh-u0Bg5_R4upMa=bM4H__i=dbvtLihFY+M+OEKdJL9w@mail.gmail.com>
Date:	Tue, 25 Oct 2011 00:50:08 +0200
From:	richard -rw- weinberger <richard.weinberger@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Jesper Juhl <jj@...osbits.net>, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Anil Ravindranath <anil_ravindranath@...-sierra.com>,
	davej@...hat.com
Subject: Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()

On Tue, Oct 25, 2011 at 12:42 AM, Joe Perches <joe@...ches.com> wrote:
> On Tue, 2011-10-25 at 00:38 +0200, Jesper Juhl wrote:
>> The first argument to kmalloc() is the size, the second is
>> flags. pmcraid_chr_ioctl() gets this wrong and swaps the
>> arguments. This patch corrects the mistake.
>>
>> Signed-off-by: Jesper Juhl <jj@...osbits.net>
>> ---
>>  drivers/scsi/pmcraid.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>>  compile tested only.
>>
>> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
>> index d079f9a..da19bdf 100644
>> --- a/drivers/scsi/pmcraid.c
>> +++ b/drivers/scsi/pmcraid.c
>> @@ -4103,7 +4103,7 @@ static long pmcraid_chr_ioctl(
>>       struct pmcraid_ioctl_header *hdr = NULL;
>>       int retval = -ENOTTY;
>>
>> -     hdr = kmalloc(GFP_KERNEL, sizeof(struct pmcraid_ioctl_header));
>> +     hdr = kmalloc(sizeof(struct pmcraid_ioctl_header), GFP_KERNEL);
>>
>>       if (!hdr) {
>>               pmcraid_err("faile to allocate memory for ioctl header\n");
>> --
>> 1.7.7
>>
>>
>
> James seems to be uninterested in picking up
> obvious and trivially correct patches.
>

BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
We could grep for "k[mzc]alloc(GFP_".

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/