linux-kernel - Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvwMEmjyifB-_Ms5Xd8iAr+GCVbYk0RX5Qxwev1nyXpFUw@mail.gmail.com>
Date:	Tue, 25 Oct 2011 01:03:36 +0200
From:	richard -rw- weinberger <richard.weinberger@...il.com>
To:	Dave Jones <davej@...hat.com>,
	richard -rw- weinberger <richard.weinberger@...il.com>,
	Joe Perches <joe@...ches.com>, Jesper Juhl <jj@...osbits.net>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Anil Ravindranath <anil_ravindranath@...-sierra.com>
Subject: Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()

On Tue, Oct 25, 2011 at 12:54 AM, Dave Jones <davej@...hat.com> wrote:
> On Tue, Oct 25, 2011 at 12:50:08AM +0200, richard -rw- weinberger wrote:
>
>  > BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
>  > We could grep for "k[mzc]alloc(GFP_".
>
> Make sure to ignore bio_kmalloc (which has reverse argument order to kmalloc, ugh)
>

Hmmm, maybe we should "fix" the argument order of bio_kmalloc().
But as this function is exported we'd silently break some out-of-tree
kernel modules....

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/