linux-kernel - Re: [PATCH] staging: iio: light: Fix compiler warning in tsl2563.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EA52710.2060108@cam.ac.uk>
Date:	Mon, 24 Oct 2011 09:51:28 +0100
From:	Jonathan Cameron <jic23@....ac.uk>
To:	Maxin B John 
	<public-maxin.john-Re5JQEeQqe8AvxtiuMwx3w@...ne.gmane.org>
CC:	Jonathan Cameron 
	<public-jic23-KWPb1pKIrIJaa/9Udqfwiw@...ne.gmane.org>,
	Dan Carpenter 
	<public-error27-Re5JQEeQqe8AvxtiuMwx3w@...ne.gmane.org>,
	Bryan Freed 
	<public-bfreed-F7+t8E8rja9g9hUCZPvPmw@...ne.gmane.org>,
	public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@...ne.gmane.org,
	Greg Kroah-Hartman <public-gregkh-l3A5Bk7waGM@...ne.gmane.org>,
	public-linux-iio-u79uwXL29TY76Z2rM5mHXA@...ne.gmane.org,
	Arnd Bergmann <public-arnd-r2nGTMty4D4@...ne.gmane.org>,
	public-devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@...ne.gmane.org,
	Amit Kucheria 
	<public-amit.kucheria-LY4KaoCqKrnby3iVrkZq2A@...ne.gmane.org>
Subject: Re: [PATCH] staging: iio: light: Fix compiler warning in tsl2563.c



On 10/22/11 06:15, Maxin B John wrote:
> Hi,
> 
> On Fri, Sep 2, 2011 at 1:55 PM, Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@...lic.gmane.org> wrote:
>> On 09/02/11 10:41, Maxin B. John wrote:
>>>> Don't overwrite the error code.  For example, the lower layers can
>>>> return -EAGAIN and that's more useful than just returning -EIO every
>>>> time.
>>> Ahh.. Thanks a lot for explaining this.
>>>
>>>> Your fix works, but it's not very clean.  Just add a "*id = ret;"
>>>> line before the "return 0;" and that's it.  (It doesn't make sense
>>>> to pass a pointer to "id" and not use it).
>>> Dan, yes, I agree with you. This fix is much much better than what I
>>> had in my mind.
>>>
>>>> Yikes - I wonder why my various compilers don't throw that up.
>>> I guess, in "iio-blue.git" tree, the 'id = 0' suppresses this warning.
>> That'd do it. oops.
>>
>> Ideally keep the white space but doesn't really matter. Either send on
>> to Greg directly or I'll add it to iio-blue and send on with the next fixes
>> series - probably this afternoon.
>>>
>>> Signed-off-by: Maxin B. John <maxin.john-Re5JQEeQqe8AvxtiuMwx3w@...lic.gmane.org>
>> Acked-by: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@...lic.gmane.org>
>>
> 
> Sorry for the delay in replying to this mail. I am curious about the
> status of this patch. I couldn't locate this patch at  iio-blue.git as
> it is not present in kernel.org now
> (http://git.kernel.org/?p=linux/kernel/git/jic23/iio-blue.git;a=summary)
> Please ignore this mail if you have already added this patch to your tree.
Ah, sorry I slipped up here and should have noticed it didn't go directly to
Greg. Just to check, with everyone I have author as Dan, reporter as Maxin
and have signed off myself (it's going through my tree anyway now).

I think from looking back it was Dan's suggestion in response to Maxin's
patch.  Hence convention would be a sign off from Dan and perhaps an
Ack from Maxin?

Jonathan

>From c33a01010decf686f5f2984d2ed04c1a70e18bc3 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Mon, 24 Oct 2011 09:46:32 +0100
Subject: [PATCH] staging:iio:light:tsl2563 missing setting of id in get id
 function.

Signed-off-by: Jonathan Cameron <jic23@....ac.uk>
Reported-by: Maxin B. John <maxin.john@...il.com>
---
 drivers/staging/iio/light/tsl2563.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
index 5cee5ca..45d04a1 100644
--- a/drivers/staging/iio/light/tsl2563.c
+++ b/drivers/staging/iio/light/tsl2563.c
@@ -227,6 +227,8 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id)
 	if (ret < 0)
 		return ret;
 
+	*id = ret;
+
 	return 0;
 }
 
-- 
1.7.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/