linux-kernel - Re: [PATCH 09/24] GFS2: Fix lseek after SEEK_DATA, SEEK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111025075435.GA5325@alboin.Mikenopa.local>
Date:	Tue, 25 Oct 2011 09:54:35 +0200
From:	Andi Kleen <ak@...ux.intel.com>
To:	Steven Whitehouse <swhiteho@...hat.com>
Cc:	cluster-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/24] GFS2: Fix lseek after SEEK_DATA, SEEK_HOLE have
 been added

On Mon, Oct 24, 2011 at 01:48:23PM +0100, Steven Whitehouse wrote:
> We need to take the inode's glock whenever the inode's size
> is referenced, otherwise it might not be uptodate. Even
> though generic_file_llseek_unlocked() doesn't implement
> SEEK_DATA, SEEK_HOLE directly, it does reference the inode's
> size in those cases, so we need to add them to the list
> of origins which need the glock.
> 
> Signed-off-by: Steven Whitehouse <swhiteho@...hat.com>
> Cc: Andi Kleen <ak@...ux.intel.com>

Looks good.

Acked-by: Andi Kleen <ak@...ux.intel.com>

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/