linux-kernel - Re: [PATCH RESEND] block: warn if tag is greater than real_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EA670F9.8030601@kernel.dk>
Date:	Tue, 25 Oct 2011 10:19:05 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Tao Ma <tm@....ma>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] block: warn if tag is greater than real_max_depth.

On 2011-10-24 17:03, Tao Ma wrote:
> Hi Jens,
> 	any option with this patch?
> 
> Thanks
> Tao
> On 09/14/2011 03:23 PM, Tao Ma wrote:
>> From: Tao Ma <boyu.mt@...bao.com>
>>
>> In case tag depth is reduced, it is max_depth not real_max_depth.
>> So we should allow a request with tag >= max_depth, but for a
>> tag >= real_max_depth, there really should be some problem.
>>
>> Cc: Jens Axboe <jaxboe@...ionio.com>
>> Signed-off-by: Tao Ma <boyu.mt@...bao.com>
>> ---
>>  block/blk-tag.c |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/block/blk-tag.c b/block/blk-tag.c
>> index ece65fc..e74d6d1 100644
>> --- a/block/blk-tag.c
>> +++ b/block/blk-tag.c
>> @@ -286,12 +286,14 @@ void blk_queue_end_tag(struct request_queue *q, struct request *rq)
>>  
>>  	BUG_ON(tag == -1);
>>  
>> -	if (unlikely(tag >= bqt->real_max_depth))
>> +	if (unlikely(tag >= bqt->max_depth)) {
>>  		/*
>>  		 * This can happen after tag depth has been reduced.
>> -		 * FIXME: how about a warning or info message here?
>> +		 * But tag shouldn't be larger than real_max_depth.
>>  		 */
>> +		WARN_ON(tag >= bqt->real_max_depth);
>>  		return;
>> +	}
>>  
>>  	list_del_init(&rq->queuelist);
>>  	rq->cmd_flags &= ~REQ_QUEUED;

Looks good, better than what we had. Applied.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/