linux-kernel - Re: [PATCHv4 4/6] input/cma3000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111025083633.GB31508@opensource.wolfsonmicro.com>
Date:	Tue, 25 Oct 2011 10:36:34 +0200
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jonathan Cameron <jic23@....ac.uk>
Cc:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	dmitry.torokhov@...il.com, sameo@...ux.intel.com,
	peter.ujfalusi@...com, aghayal@...eaurora.org, david@...deman.nu,
	Shubhrajyoti@...com, saaguirre@...com, hemanthv@...com,
	linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv4 4/6] input/cma3000_d0x: Add CMA3000 spi support

On Tue, Oct 25, 2011 at 09:32:27AM +0100, Jonathan Cameron wrote:
> On 10/25/11 08:24, Ricardo Ribalda Delgado wrote:

> > It is not on linux-next, and also it cannot be used directly, in order
> > to read you have to do set reg= (reg << 2) | 2; And AFAIK it is not
> > supported by the regmap

> My gut feeling is it would easy enough to add if it can't currently
> be done. Mark?

That should be trivial to add - the | 2 bit is already supported in
-next and will be sent to Linus this merge window, adding the shift is
just a simple matter of programming.

> Gains here are leveraging the bus abstractions from there.  There aren't
> enough registers to gain from caching etc.

Depends on the workload more than the number of registers - if you're
able to eliminate enough reads then it can give a bit of a performance
boost.  But it's completely optional either way.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/