linux-kernel - Re: [PATCH 2/4] ipc/mqueue: switch back to using non-max values on create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHGf_=obvkUN-JYVfbLueTV3hmobnV3jY86ukHo1E6d-3NDZxg@mail.gmail.com>
Date:	Mon, 24 Oct 2011 20:56:44 -0400
From:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
To:	Doug Ledford <dledford@...hat.com>
Cc:	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, joe.korty@...r.com, amwang@...hat.com
Subject: Re: [PATCH 2/4] ipc/mqueue: switch back to using non-max values on create

> Commit b231cca4381ee15ec99afbfb244fbc0324869927 changed
> how we create a queue that does not include an attr
> struct passed to open so that it creates the queue
> with whatever the maximum values are.  However, if the
> admin has set the maximums to allow flexibility in
> creating a queue (aka, both a large size and large queue
> are allowed, but combined they create a queue too large
> for the RLIMIT_MSGQUEUE of the user), then attempts to
> create a queue without an attr struct will fail.  Switch
> back to using acceptable defaults regardless of what
> the maximums are.
>
> Signed-off-by: Doug Ledford <dledford@...hat.com>

NAK.

Commit b231cca is 3 years old commit. It's too late to revert.
Moreover Commit b231cca changed hardcoded limit to kernel knob,
and this patch do reverse. Of course, latter direction changes almost
always bring us compatibility issue.

   commit b231cca4381ee15ec99afbfb244fbc0324869927
   Author: Joe Korty <joe.korty@...r.com>
   Date:   Sat Oct 18 20:28:32 2008 -0700

       message queues: increase range limits

The right way is to create new knob likes mqueue/msgsize_default
and to separate default and maximum value.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/