[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111025114406.GC10182@redhat.com>
Date: Tue, 25 Oct 2011 13:44:06 +0200
From: Andrea Arcangeli <aarcange@...hat.com>
To: Shaohua Li <shaohua.li@...el.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
linux-mm <linux-mm@...ck.org>,
lkml <linux-kernel@...r.kernel.org>
Subject: Re: [patch 1/5]thp: improve the error code path
Hello,
On Tue, Oct 25, 2011 at 10:58:41AM +0800, Shaohua Li wrote:
> +#ifdef CONFIG_SYSFS
> + sysfs_remove_group(hugepage_kobj, &khugepaged_attr_group);
> +remove_hp_group:
> + sysfs_remove_group(hugepage_kobj, &hugepage_attr_group);
> +delete_obj:
> + kobject_put(hugepage_kobj);
> out:
> +#endif
Adding an ifdef is making the code worse, the whole point of having
these functions become noops at build time is to avoid having to add
ifdefs in the callers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists