linux-kernel - Re: [GIT] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzYW_Pku3ESH8HHHkGMu+G9UZPUSLajZy=edEnQ+vycNg@mail.gmail.com>
Date:	Tue, 25 Oct 2011 14:03:09 +0200
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Greg KH <gregkh@...e.de>
Cc:	David Miller <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Mikulas Patocka <mpatocka@...hat.com>,
	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT] Networking

On Tue, Oct 25, 2011 at 1:56 PM, Greg KH <gregkh@...e.de> wrote:
>
> The "crazy" tool was using 'git am'.  The problem was that I missed the
> fact that the first line of the patch sent to me duplicated the subject
> line.  It's a really common problem when people generate patches and
> send them off by email, I just forgot to edit the patches from Mikulas
> to remove them, my fault, sorry.

Ok, please (a) check these things before applying patches, and (b)
COMPLAIN TO EVERY SOURCE THAT SENDS YOU CRAP.

The push-back so that it doesn't happen again is important.

In other words: Mikulas - whatever tool you're using, stop using it,
or start using it correctly. Duplicating the header line in the body
of the email is crap and wrong. If you want to duplicate it in the
email, add the "Subject:" prefix to it (same goes for "Date:" and
particularly "From:" - those fields are actually destroyed by
forwarding the patches over email - unlike the subject line)

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/